Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker + API design scripts #20

Merged
merged 5 commits into from
May 21, 2020
Merged

Conversation

Ehbraheem
Copy link
Collaborator

This PR adds docker build helper scrips + API doc generation script.

Copy link
Collaborator

@jabdul jabdul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ehbraheem
Copy link
Collaborator Author

Could you add the shell scripts to this:

https://github.com/jabdul/tripbot/tree/204665a18293fec41b6656f05392894a921797ce/packages/accounts

Yeah sure 👍

@jabdul
Copy link
Collaborator

jabdul commented May 20, 2020

Could you add the shell scripts to this:
https://github.com/jabdul/tripbot/tree/204665a18293fec41b6656f05392894a921797ce/packages/accounts

Yeah sure 👍

I think you misunderstood the request. Although you can keep the changes you've already made. However, what I meant was that you copy the doc.sh and doc_lint.sh in the scripts folder over to this PR:

https://github.com/jabdul/tripbot/tree/204665a18293fec41b6656f05392894a921797ce/packages/accounts/scripts

@Ehbraheem
Copy link
Collaborator Author

Could you add the shell scripts to this:
https://github.com/jabdul/tripbot/tree/204665a18293fec41b6656f05392894a921797ce/packages/accounts

Yeah sure 👍

I think you misunderstood the request. Although you can keep the changes you've already made. However, what I meant was that you copy the doc.sh and doc_lint.sh in the scripts folder over to this PR:

https://github.com/jabdul/tripbot/tree/204665a18293fec41b6656f05392894a921797ce/packages/accounts/scripts

Oh. I already did. I spied on your commits. 😄

@Ehbraheem Ehbraheem requested a review from jabdul May 20, 2020 17:13
@Ehbraheem Ehbraheem merged commit cf11dbd into master May 21, 2020
@Ehbraheem Ehbraheem deleted the feature/docker-api-scrips branch May 21, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants