Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python3 support and fix Rados.mon_command call for ceph pacific #65

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

AzadShM
Copy link

@AzadShM AzadShM commented Aug 23, 2021

these commits:

  • add support for python3 Resolves ceph-dash does not work with python3 #66

      * mostly using 2to3
      * added try / except to import urlopen
        to support python2 and python3
      * add try / except to _string_decode_hook
        unicode no longer exists in python3 (the code probably never worked with utf-8 characters
        in python2 anyway but i kept the old behavior, this might not be the best way to deal with it, ideas?)
    
  • fix Rados.mon_command() for ceph pacific resolves ceph-dash does not work with ceph pacific 16.2.5 #67

      ceph pacific expects the inbuf argument to be passed as bytes and not str
      this should work fine for older versions too
      see:
      https://bugs.launchpad.net/cinder/+bug/1913449
      https://github.com/ceph/ceph/commit/51a2a72215ac93836ccc37733607b8e97d808e10
    

  * mostly using 2to3
  * added try / except to import urlopen
    to support python2 and python3
  * add try / except to _string_decode_hook
    unicode no longer exists in python3
@Crapworks Crapworks merged commit 90f1d64 into Crapworks:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ceph-dash does not work with ceph pacific 16.2.5 ceph-dash does not work with python3
2 participants