Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline run() and connect() commands #203

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

billschereriii
Copy link
Contributor

Streamline run and connect commands for Redis and RedisCluster to make sure that retries happen when they should and appropriate messages are generated when operations fail.

@billschereriii billschereriii added the area: C++ Issues related to the C++ client label Feb 1, 2022
@billschereriii billschereriii self-assigned this Feb 1, 2022
@billschereriii
Copy link
Contributor Author

fixes #203

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022

Codecov Report

Merging #203 (7f75fed) into develop (de59471) will decrease coverage by 0.47%.
The diff coverage is 10.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #203      +/-   ##
===========================================
- Coverage    82.98%   82.51%   -0.48%     
===========================================
  Files           50       50              
  Lines         2827     2836       +9     
===========================================
- Hits          2346     2340       -6     
- Misses         481      496      +15     
Impacted Files Coverage Δ
src/cpp/redis.cpp 72.40% <10.00%> (-3.54%) ⬇️
src/cpp/commandreply.cpp 68.58% <0.00%> (-1.77%) ⬇️

Copy link
Collaborator

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup -- LGTM

@billschereriii billschereriii merged commit 7c742b5 into CrayLabs:develop Feb 1, 2022
@billschereriii billschereriii deleted the connectretry branch February 1, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: C++ Issues related to the C++ client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants