Add Python 3.11 and remove Python 3.7 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the versions we have explicitly prevent SmartRedis from being installed with Python 3.11. After testing, SmartRedis needs no changes for full compatibility.
Python 3.7 has reached end of life and therefore we are removing support for this version.
MattToast
changed the title
MattToast
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Looks great! Just a couple of minor requests to tag on:
- Can you update the
.github/workflows/run_tests.ymlto include Py 3.11? - Can you update the
doc/overview.rstto include3.11@ ~line 53 - Can you add something to the changelog, just so that we do not forget to call this out when we release, lol?
|
Oh! And can you touch these lines in the docs since we are removing references to 3.7 as well? |
|
Thanks for the quick review. Let me know if there's anything else that you can see |
MattToast
approved these changes
Jan 19, 2024
Closed
al-rigazzi
pushed a commit
to al-rigazzi/SmartRedis
that referenced
this pull request
Feb 12, 2024
Python 3.7 has reached end of life. Additionally, work has been done on the SmartSim side to confirm that updated versions of the ML backends which do support 3.11 are compatible with SmartSim and SmartRedis. This PR thus removes support for 3.7 and adds support for 3.11 [ committed by @ashao ] [ reviewed by @MattToast ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7 has reached end of life. Additionally, work has been done on the SmartSim side to confirm that updated versions of the ML backends which do support 3.11 are compatible with SmartSim and SmartRedis. This PR thus removes support for 3.7 and adds support for 3.11