Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 and remove Python 3.7 #450

Merged
merged 3 commits into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
matrix:
os: [ubuntu-22.04] # cannot test on macOS as docker isn't supported on Mac
rai_v: [1.2.7] # versions of RedisAI
py_v: ['3.8.x', '3.9.x', '3.10.x'] # versions of Python
py_v: ['3.8.x', '3.9.x', '3.10.x', '3.11.x'] # versions of Python
compiler: [nvhpc-23-11, intel-2024.0, gcc-11, gcc-12] # intel compiler, and versions of GNU compiler
link_type: [Static, Shared]
env:
Expand Down
4 changes: 4 additions & 0 deletions doc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ To be released at some future point in time

Description

- Update supported python versions [Add 3.11, remove 3.7]
- Tweak the build system to enable building SmartRedis with Nvidia's NVHPC toolchain
- Improvements/upgrades to the container used for Github actions
- Code updates to avoid compiler warnings
Expand All @@ -17,6 +18,8 @@ Description

Detailed Notes

- Deprecate support for Python 3.7 by removing from the allowed Python versions (PR450_)
- Update Python package dependencies to add support for Python 3.11 (PR450_)
- Change the order of arguments in our MakeFile to ensure that all dependencies are compiled with GCC (PR448_)
- Add new user-configurable parameters DEP_CC, DEP_CXX to control which compiler is used to build dependencies (PR448_)
- Ameliorate some compiler warnings related that were flagged in GCC 12 (unreachable code blocks, signed/unsigned mismatches) (PR448_)
Expand All @@ -31,6 +34,7 @@ Detailed Notes
- Resolve a linting issue with pybind-to-python error propagation by changing import format and narrowing the lookup of pybind error names to the error module (PR444_)
- Use mutable fields to enable Dataset get methods that store memory to be marked const (PR443_)

.. _PR450: https://github.com/CrayLabs/SmartRedis/pull/450
.. _PR448: https://github.com/CrayLabs/SmartRedis/pull/448
.. _PR445: https://github.com/CrayLabs/SmartRedis/pull/445
.. _PR444: https://github.com/CrayLabs/SmartRedis/pull/444
Expand Down
3 changes: 1 addition & 2 deletions doc/install/python_client.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ the ``Client`` from ``smartredis`` as follows:

.. code-block:: python

Python 3.7.7 (default, May 7 2020, 21:25:33)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Python 3.11.7 (main, Jan 12 2024, 20:10:36) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from smartredis import Client
>>>
2 changes: 1 addition & 1 deletion doc/overview.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ below summarizes the language standards for each client.
* - Language
- Version/Standard
* - Python
- 3.7, 3.8, 3.9, 3.10
- 3.8-3.11
* - C++
- C++17
* - C
Expand Down
6 changes: 3 additions & 3 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ contact_email = craylabs@hpe.com
license = BSD 2-Clause License
keywords = redis, clients, hpc, ai, deep learning
classifiers =
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
License :: OSI Approved :: BSD License
Intended Audience :: Science/Research
Topic :: Scientific/Engineering
Expand All @@ -34,7 +34,7 @@ setup_requires =
include_package_data = True
install_requires =
numpy>=1.18.2
python_requires = >=3.7,<3.11
python_requires = >=3.8,<3.12


[options.extras_require]
Expand All @@ -44,7 +44,7 @@ dev =
black==23.3.0
isort==5.6.4
pylint>=2.10.0
torch==1.11.0
torch<=2.0.1
mypy>=1.4.0
jinja2==3.0.3

Expand Down
Loading