Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fixed width integers by default and update documentation #145

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

@liamnichols
Copy link
Member Author

I'm still on the fence as to wether we want this as the default behaviour or not 😅 Before merging I might double check some other generators to see how they handle fixed-width integers by default.

@LePips
Copy link
Contributor

LePips commented Aug 15, 2022

I ultimately think whatever is fine. I just have the thought that we should generate as closely to the schema as possible by default and then it's configurable to change that behavior.

@liamnichols
Copy link
Member Author

So SwagGen has a similar fixedWidthIntegers flag that is false by default, and openapi-generator uses fixed width integers by default so I'm going to stick with this change and change the default behaviour 👍

@liamnichols liamnichols marked this pull request as ready for review August 16, 2022 18:20
@liamnichols liamnichols self-assigned this Aug 16, 2022
@liamnichols liamnichols merged commit adb3b8d into main Aug 16, 2022
@liamnichols liamnichols deleted the ln/dataType-tests branch August 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants