Refactor: Cleans up scss #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,6 @@ | |||
| @import "fonts"; | |||
| @import "vars"; | |||
| @import "mixins"; | |||
There was a problem hiding this comment.
The mixins file doesn't exist anymore, does it?
There was a problem hiding this comment.
Or rather: there doesn't seem to be anything in it anymore, so it should be removed.
There was a problem hiding this comment.
Both vars.scss and mixins.scss still exist as empty files. My thinking is that I (and probably others too) want those files for every new project and so I'd like to save the keystrokes and mouse clicks that it takes to create and import those files. To me much of the appeal of a tool like this is to be relieved of tedious manual labour
|
Bump! @pellebjerkestrand Merging this tonight unless there's any more activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scss files contained some bloat that probably isn't necessary.
I left some things in
site.css:box-sizingbecause I can't imagine a project where havingcontent-boxorpadding-boxas default makes sense.-webkit-font-smoothing: This is necessary in order for fonts to render properly on MacOS. I don't think everyone cares about this (except for the designers of course) so I think it's a good idea to have it as a default..mouse-user: Half the point of includinginput-detection.jsis to disable focus outlines for mouse users