Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micro-Byte on Array #11

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Micro-Byte on Array #11

merged 2 commits into from
Oct 19, 2020

Conversation

divyanshrastogi51
Copy link
Contributor

This PR Solve #10

Kevinpaulose05
Kevinpaulose05 reviewed Oct 19, 2020
View reviewed changes
Copy link
Member

@Kevinpaulose05 Kevinpaulose05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @divyanshrastogi51 . Just a few things u can add to complete this PR.

  1. Put a couple of code examples in a folder named 'src' within ur microbyte.
  2. Open an issue with this topic in Getting Started with DSA microbyte and make this PR there too in the correct folder.

Microbyte structure is pretty good(only 'src' is missin)!
Maybe next time you an pick better topics. Arrays are very basic. U can combine multiple easy concepts too.

Kevinpaulose05
Kevinpaulose05 approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@Kevinpaulose05 Kevinpaulose05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time try picking a mixed or tougher concept than this. For first PR this is fine.

@Kevinpaulose05 Kevinpaulose05 added the hacktoberfest-accepted Accept for hactoberfest, will merge later label Oct 19, 2020
@divyanshrastogi51
Copy link
Contributor Author

Ya sure. but I did not understand the 2nd point. I have mentioned the issue

@Kevinpaulose05
Copy link
Member

Nicely done @divyanshrastogi51 . Just a few things u can add to complete it

Ya sure. but I did not understand the 2nd point. I have mentioned the issue

What i mean is u can simply contribute to that microbyte so that Getting Started with DSA will have more DSA to its collection and also u will get a PR

archithdwij
archithdwij approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@archithdwij archithdwij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good structure maintenance @divyanshrastogi51 . Your content is well - detailed. Good job! looking forward for more contributions.

@Kevinpaulose05
Copy link
Member

Pls mention the files in ur src folder in the readme so that ppl will know what exits in src.

@YourAKShaw
Copy link
Member

YourAKShaw commented Oct 19, 2020 •
edited
Loading

Ya sure. but I did not understand the 2nd point. I have mentioned the issue

Kindly refer this for PR description template.

Coming to the content. LGTM! We'll merge it once you update the PR description with proper template.

@Kevinpaulose05 Kevinpaulose05 merged commit 7010246 into Crio-Bytes:main Oct 19, 2020
@YourAKShaw
Copy link
Member

@all-contributors kindly add @divyanshrastogi51 for code doc ideas content

@allcontributors allcontributors bot mentioned this pull request Oct 19, 2020
Merged
@allcontributors
Copy link
Contributor

@Ak-Shaw

I've put up a pull request to add @divyanshrastogi51! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archithdwij archithdwij archithdwij approved these changes

@Kevinpaulose05 Kevinpaulose05 Kevinpaulose05 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accept for hactoberfest, will merge later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyanshrastogi51 @Kevinpaulose05 @YourAKShaw @archithdwij