Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pages/admin): fix layer name autofill from incident name for admin incident wizard #665

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

deepanchal
Copy link
Contributor

@deepanchal deepanchal commented Jan 12, 2024

Description

Peek.2024-01-12.15-31.webm

Screenshots

Related Issue

Ref: #128

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Does this introduce a breaking change?

  • Yes
  • No

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (7614db0) 16.12% compared to head (5a1bd83) 16.12%.

Files Patch % Lines
...ponents/admin/incidents/IncidentLocationEditor.vue 0.00% 12 Missing ⚠️
src/pages/admin/AdminIncidentWizard.vue 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   16.12%   16.12%   -0.01%     
==========================================
  Files         353      353              
  Lines       75327    75337      +10     
  Branches      801      801              
==========================================
  Hits        12149    12149              
- Misses      63178    63188      +10     
Flag Coverage Δ
unitTests 16.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  21 passed
flaky  5 flaky

Details

stats  26 tests across 12 suites
duration  3 minutes, 42 seconds
commit  5a1bd83

Flaky tests

firefox-setup → auth.setup.ts → authenticate as user - ( @primary @slow @READ @development @staging @production )
chromium → authentication.test.ts → Authentication → should load unauthorized routes as expected with and without authentication - ( @slow @primary @development @staging @production )
firefox → pages/login.test.ts → LoginPage → should have data-testids - ( @fast @primary @READ @development @staging @production )
firefox → pages/myOrganization.test.ts → MyOrganization → Invitation Management: should display all required elements - ( @primary @slow @READ @development @staging @production )
firefox → pages/reports.test.ts → Reports → should have visible data-testids - ( @primary @slow @READ @development @staging @production )

@deepanchal deepanchal merged commit 24353f7 into master Jan 12, 2024
16 of 18 checks passed
@deepanchal deepanchal deleted the fix/admin-wizard-location-name-fill branch January 12, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant