Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable non SSL code on SSL macro #206

Merged
merged 1 commit into from
Aug 21, 2021
Merged

Disable non SSL code on SSL macro #206

merged 1 commit into from
Aug 21, 2021

Conversation

The-EDev
Copy link
Member

Disclaimer: SSL refers to the OpenSSL library, not the SSL protocol.

Crow used to keep the non SSL code if SSL is enabled, This PR makes it so that at a time, either SSL code is there or non SSL code is there (you will get an error if you define the CROW_ENABLE_SSL macro without defining a certificate).

This is a matter of preference, I have no problem scrapping it and its issue.

Closes #67

@The-EDev The-EDev added the feature Code based project improvement label Aug 21, 2021
@The-EDev The-EDev requested a review from mrozigor August 21, 2021 02:37
@The-EDev The-EDev merged commit 7d0e441 into master Aug 21, 2021
@The-EDev The-EDev deleted the ssl_no_deadcode branch August 21, 2021 22:41
@The-EDev The-EDev mentioned this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Code based project improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling SSL leaves http code without any actual use
2 participants