Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC 8.3 workaround #287

Merged
merged 8 commits into from
Dec 4, 2021
Merged

GCC 8.3 workaround #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a05765
GCC 8 workaround
nx10 Nov 23, 2021
58e2113
Constrain and warn GCC 8 bug
nx10 Nov 25, 2021
df50e33
Spelling
nx10 Nov 25, 2021
7ee13c4
GCC 8 workaround compiler detection & error
nx10 Nov 27, 2021
62b74a1
Merge branch 'master' into gcc8-workaround
The-EDev Nov 27, 2021
9c55181
Merge branch 'master' into gcc8-workaround
The-EDev Nov 29, 2021
24d8a72
Update include/crow/app.h
nx10 Dec 4, 2021
63c8af7
Merge branch 'master' into gcc8-workaround
The-EDev Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions include/crow/app.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,16 @@ namespace crow
return router_.new_rule_dynamic(std::move(rule));
}

/// Create a route using a rule (**Use CROW_ROUTE instead**)
///Create a route using a rule (**Use CROW_ROUTE instead**)
template<uint64_t Tag>
#ifdef CROW_GCC83_WORKAROUND
auto& route(std::string&& rule)
#else
auto route(std::string&& rule)
#ifdef CROW_CAN_USE_CPP17
#endif
#if defined CROW_CAN_USE_CPP17 && !defined CROW_GCC83_WORKAROUND
-> typename std::invoke_result<decltype(&Router::new_rule_tagged<Tag>), Router, std::string&&>::type
#else
#elif !defined CROW_GCC83_WORKAROUND
-> typename std::result_of<decltype (&Router::new_rule_tagged<Tag>)(Router, std::string&&)>::type
#endif
{
Expand Down
8 changes: 8 additions & 0 deletions include/crow/settings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,11 @@
#define noexcept throw()
#endif
#endif

#if defined(__GNUC__) && __GNUC__ == 8 && __GNUC_MINOR__ < 4
#if __cplusplus > 201103L
#define CROW_GCC83_WORKAROUND
#else
#error "GCC 8.1 - 8.3 has a bug that prevents crow from compiling with C++11. Please update GCC to > 8.3 or use C++ > 11."
#endif
#endif