-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCC 8.3 workaround #287
GCC 8.3 workaround #287
Conversation
Thanks a lot for the work and comprehensive PR description. I have 2 concerns (or suggestions) however, the first being the fact that you're immediately checking the value of When it comes to the support scope of the project, we started development with support for newer and older Boost versions, the library has a workaround for Visual Studio 13 (I believe). And we recently added C++20 support (in the sense that the program will compile out of the box). So as long as the change won't require too much expansion in the future, I don't see a reason not to integrate it. Thanks again for your work and please let me know when the PR is ready for review. Tests are already passing and as far as I can tell there aren't any formatting errors. |
Thank you for your quick response. I agree with and have added your suggestions. |
Testing it out in godbolt, I'm getting the following error when using
The problem seems to be that Everything else seems to be working fine (including the |
Co-authored-by: Farook Al-Sammarraie <farook@the-e-dev.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once the tests are done
Compilation with GCC 8.1 - 8.3 is failing due to a compiler bug. I spent some time confirming which GCC versions are affected and it seems to be fixed in in GCC 8.4 (also fixed with GCC 9.1). (Compiler explorer: https://godbolt.org/z/beWsMznd5)
Issues referencing this problem:
This PR applies the workaround suggested in ipkn/crow#303 (comment) if one of the affected GCC versions is used. It also throws a preprocessor warning with instructions to upgrade either GCC version or C++ standard if it can not be applied.
I am not sure this workaround is in the support scope for this project, so it is fine for me if it is rejected. (It might still be helpful to stay open indefinitely for somebody who has to support GCC 8 < 8.4)