Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad tenant url on tenant creation #190

Merged
merged 5 commits into from Nov 9, 2022
Merged

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Nov 8, 2022

Changes proposed ✍️

  • On tenant create, we were setting the tenant.url as a random uuid when the data payload didn't have the url field. Now we're generating a tenant url from the tenant name and checking for duplication problems as well since url needs to be unique
  • The previous uuid approach was creating a problem when publishing community help center of a tenant (The url comes populated with uuids)
  • Also refactored out getCleanString function to utils, to also use it in tenantRepository

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit ec2d6e8
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/636a97c3563e110008493048

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit ec2d6e8
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/636a97c3a75ab30008221c02

@epipav epipav self-assigned this Nov 8, 2022
@epipav epipav marked this pull request as ready for review November 8, 2022 17:40
@epipav
Copy link
Collaborator Author

epipav commented Nov 8, 2022

@joanreyero after merge we'll need to update the tenant urls of prod tenants that have uuid in them

@epipav epipav merged commit 78d5675 into main Nov 9, 2022
@epipav epipav deleted the bugfix/bad-tenant-url-on-signup branch November 9, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants