Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary displayName updates in data-sink-worker #1372

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Aug 22, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 3534e0c

Improved logic for setting member display name in member.service.ts. Prevented overwriting existing display name when processing message queue data.

🤖 Generated by Copilot at 3534e0c

displayName set
No need to update again
Save user's winter

Why

How

🤖 Generated by Copilot at 3534e0c

  • Prevent overwriting display name in database by checking if it is already set (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 9a7d6e4 into main Aug 22, 2023
9 checks passed
@garrrikkotua garrrikkotua deleted the fix/prevent-displayname-update branch August 22, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant