Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent timestamps throughout the app #1375

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Aug 22, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at f365c5f

This pull request fixes some bugs and adds some features related to date filters and dashboard data. It ensures that the date filters use UTC time and include today's data, and that the dashboard and widget components use consistent and accurate filter options and query parameters. It also simplifies and cleans up some code in various components and modules, and adds some customization options for the chart display. It affects files in the frontend/src/modules and frontend/src/shared/modules directories, as well as the frontend/src/modules/dashboard/dashboard.cube.js file.

🤖 Generated by Copilot at f365c5f

Oh we're the coders of the dashboard, and we work with skill and speed
We fix the bugs and add the features, and we use the filterQueryService
We make the dates and pivots right, and we simplify the code
So heave away and pull the rope, and watch the data load

Why

How

🤖 Generated by Copilot at f365c5f

  • Add and use filterQueryService to convert filter objects to query strings for API requests (link, link, link, link, link, link, link, link)
  • Modify date filter options to use UTC time and subtract one less day from moment objects to include today's data (link, link, link, link, link, link)
  • Simplify date range calculation by removing unnecessary conditional check for granularity and using period value directly (link, link, link, link, link, link)
  • Modify filter objects in dashboard store actions to use UTC time and subtract one less day from moment objects, and set start and end of day for date range (link, link, link, link, link, link)
  • Modify date range for widget queries to use UTC time and subtract one less day from moment objects (link, link, link, link, link, link)
  • Modify dateApiFilterRenderer function to use UTC time for moment objects (link)
  • Add pivotModifier prop to widget-area component and use it to remove date dimension from pivot array for chart display (link, link, link, link, link)
  • Replace newAndActive filter with allOrganizations filter in dashboard-organizations component (link)
  • Replace newAndActive filter with allMembers filter in dashboard-members component (link)
  • Define allConversationsFilter, allActivitiesFilter, allMembers, and allOrganizations as computed properties for dashboard components (link, link, link, link)
  • Remove unused imports and functions from widget components (link, link, link)
  • Add empty lines to dashboard store actions file for readability and formatting (link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Aug 22, 2023
@joanagmaia joanagmaia self-assigned this Aug 22, 2023
@joanagmaia joanagmaia merged commit 69c1cee into main Aug 24, 2023
7 checks passed
@joanagmaia joanagmaia deleted the improvement/consistent-timestamps branch August 24, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants