-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cubejs #1391
Merged
Merged
Improve cubejs #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's created every time after deployment with cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 4455d7c
This pull request refactors and simplifies the Cube.js schema files to use materialized views and table names instead of raw SQL queries, and to remove unnecessary or redundant fields. This improves the performance, readability, and maintainability of the Cube.js application. It also adds a SQL script to create and index the materialized views, and modifies the
CrowdJob
interface and the logging utility to use a custom logger.
🤖 Generated by Copilot at 4455d7c
Why
How
🤖 Generated by Copilot at 4455d7c
Activities
,Members
,Organizations
, andSegments
cube schemas to improve performance and scalability (link, link, link, link, link)Activities
,Conversations
,Members
, andSentiment
cube schemas by removing unnecessary or redundant fields and using existing fields from materialized views or SQL queries (link, link, link, link, link)Conversations
,MemberOrganizations
, andOrganizationSegments
cube schemas to follow Cube.js convention and avoid confusion with template literals (link, link, link, link)MemberOrganizations
,MemberSegments
,MemberTags
,OrganizationSegments
, andTags
cube schemas as they do not require any complex transformations or aggregations (link, link, link, link, link, link)MemberOrganizations
,MemberSegments
, andOrganizationSegments
cube schemas as they are only used as join tables for other cubes and do not have any meaningful metrics or attributes (link, link, link, link)id
field toSentiment
cube schema SQL query to ensure a unique identifier for each row and avoid potential errors or duplicates (link)Identities
andMemberIdentities
cube schemas as they are no longer used by the application (link, link)log
parameter toonTrigger
function ofCrowdJob
interface to allow job functions to use custom logger from@crowd/logging
library (link)logExecutionTimeV2
utility function that useslog
parameter to log execution time of a given process and replace existinglogExecutionTime
function that uses default console logger (link).cubecloud
folder to.gitignore
file to ignore Cube Cloud service folder that may contain sensitive information or configuration details (link)Checklist ✅
Feature
,Improvement
, orBug
.