Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor location attribute formatting in organization enrichment #1393

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented Aug 30, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at fa42a1e

Refactored the organizationEnrichmentService to return a simpler and more uniform data object for the frontend. Removed unnecessary or redundant fields from the backend/src/services/premium/enrichment/organizationEnrichmentService.ts file.

🤖 Generated by Copilot at fa42a1e

organizationEnrichmentService
Returns data object / Simplified and consistent
For the UI's ease

Why

How

🤖 Generated by Copilot at fa42a1e

  • Simplify the location field of the organization data object to only include relevant information for the UI (link)
  • Delete the inferredRevenue field of the organization data object as it is not used or stored anywhere (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 added the Improvement Created by Linear-GitHub Sync label Aug 30, 2023
@garrrikkotua garrrikkotua self-requested a review August 30, 2023 08:08
@yeganathan18 yeganathan18 merged commit 4e03354 into main Aug 30, 2023
9 checks passed
@yeganathan18 yeganathan18 deleted the improvement/locationData branch August 30, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants