Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displayName sorter in members and organizations list #1406

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented Aug 31, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 372d4d8

This pull request adds or modifies the sorting functionality for the display names and the organization names in the list tables. It uses the sortable attribute of the el-table-column component and a custom opensearch query parser to achieve case-insensitive sorting for the display names.

🤖 Generated by Copilot at 372d4d8

Sorting display names
keyword type for winter
Custom or default

Why

How

🤖 Generated by Copilot at 372d4d8

  • Enable case-insensitive sorting of display names in member list table (link, link)
  • Add default sorting functionality to name column in organization list table (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 added the Bug Created by Linear-GitHub Sync label Aug 31, 2023
@yeganathan18 yeganathan18 self-assigned this Aug 31, 2023
@yeganathan18 yeganathan18 merged commit 2b98f58 into main Aug 31, 2023
11 checks passed
@yeganathan18 yeganathan18 deleted the bugfix/display-name-sorter branch August 31, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants