Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize website while creating organization #1412

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented Sep 1, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at b2dd48d

This pull request adds a websiteNormalizer function to the @crowd/common library and uses it in the organizationService and the organization.service to normalize the website URLs of organizations. This ensures that the website URLs are consistent and valid across the application and the databases.

🤖 Generated by Copilot at b2dd48d

Sing, O Muse, of the skillful websiteNormalizer
That from the @crowd/common library shone forth
And gave to many services a precious boon
To cleanse the URLs of organizations from all flaws

Why

How

🤖 Generated by Copilot at b2dd48d

  • Define and export websiteNormalizer function in @crowd/common library to normalize website URLs of organizations (link, link)
  • Import and use websiteNormalizer function in organizationService.ts to normalize website URLs before creating or updating organizations in the main database (link, link, link)
  • Import and use websiteNormalizer function in organization.service.ts to normalize website URLs before sending organizations to the data sink worker (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 added the Improvement Created by Linear-GitHub Sync label Sep 1, 2023
@yeganathan18 yeganathan18 merged commit d521f2f into main Sep 1, 2023
9 checks passed
@yeganathan18 yeganathan18 deleted the improvement/email-domain branch September 1, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants