-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text-based filter in members page for Member names #1427
Conversation
@joanagmaia this is good to go, hopefully |
); | ||
}, | ||
apiFilterRenderer(value: StringFilterValue): any[] { | ||
return apiFilterRendererByType[FilterConfigType.STRING]('displayName', value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if you notice on string.label.renderer.ts
file we do this:
const excludeText = !include ? ' (exclude)' : '';
And since we are not passing any include value, the filter is getting updated like this:
Can you also update the following:
- On
frontend/src/shared/modules/filters/types/filterTypes/StringFilterConfig.ts
addinclude: boolean
toStringFilterValue
- Then on
frontend/src/shared/modules/filters/components/filterTypes/StringFilter.vue
updatedefaultForm
to
const defaultForm: StringFilterValue = {
value: '',
include: true,
operator: FilterStringOperator.LIKE,
};
This won't render the Include Checkbox. It's just a fix to make sure that we don't render (exclude) when we are actually including.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, changes made :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Will try to ship it today 😄
Changes proposed ✍️
What
Fixes #1239
🤖 Generated by Copilot at 1cfca44
Added a new
memberName
filter for members in the frontend UI. Created a new filememberName/config.ts
to define the filter config and imported it infilters/main.ts
.
🤖 Generated by Copilot at 1cfca44
Why
How
🤖 Generated by Copilot at 1cfca44
memberName
filter config for filtering members by name (link)memberName
filter config inmain.ts
(link)Checklist ✅
Feature
,Improvement
, orBug
.