Add multi-select filter in organizations page for Headcount #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanagmaia
requested changes
Sep 6, 2023
| const filter = { | ||
| size: { eq: value }, | ||
| or: value.map((count) => ({ size: count })), |
There was a problem hiding this comment.
Here it needs to be:
or: value.map((count) => ({ size: { eq: count } })),
Otherwise API returns 500
Comment on lines
26
to
29
| { | ||
| label: '> 1000', | ||
| value: '1000+', | ||
| }, |
There was a problem hiding this comment.
The issue scoping was not completely ok.
This specific attribute is following the canonical values from https://docs.peopledatalabs.com/docs/company-sizes
Instead of this new selection item, can you add support for
1001-5000
5001-10000
10001+
instead?
Apologies for the confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
Fixes #1242
🤖 Generated by Copilot at 3550e33
The headcount filter for organizations was improved to allow more flexibility and granularity. Users can now select multiple headcount ranges, including a new option for
>1000, and the filter config and options were modified to support this feature.
🤖 Generated by Copilot at 3550e33
Why
How
🤖 Generated by Copilot at 3550e33
Checklist ✅
Feature,Improvement, orBug.