Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback in org affiliation only to those which have no dates #1436

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

sausage-todd
Copy link
Contributor

@sausage-todd sausage-todd commented Sep 6, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 174d84c

The pull request updates the logic for filtering out temporary member organizations in various backend classes and methods. This improves the accuracy and consistency of the member profile, dashboard, permissions, roles, and affiliation score features.

🤖 Generated by Copilot at 174d84c

Sing, O Muse, of the cunning code change that refined the score
Of the noble members who join the platform with many a bond
And of the wise developers who filtered the SQL query
To exclude the fleeting organizations that have a dateEnd

Why

How

🤖 Generated by Copilot at 174d84c

  • Filter out member organizations with dateStart or dateEnd values in SQL queries to only include current or permanent member organizations in member affiliation score calculation and member organization fetching (link, link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@sausage-todd sausage-todd merged commit 7110b6a into main Sep 6, 2023
9 checks passed
@sausage-todd sausage-todd deleted the fallback-affiliate-orgs-only-without-dates branch September 6, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant