Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to improve negative filters ux #1437

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Sep 6, 2023

Changes proposed ✍️

What

Fixes #963

🤖 Generated by Copilot at 2b237c5

Improved the UI and UX of the filter include switch component in FilterIncludeSwitch.vue by adding a tooltip and adjusting the layout. Fixed a CSS issue with the switch label in switch.scss.

🤖 Generated by Copilot at 2b237c5

To fix a switch label that grew
The grow class was changed to grow-0
And to make it more clear
What the filter does here
A tooltip was added anew

Why

How

🤖 Generated by Copilot at 2b237c5

  • Align switch and label vertically and add tooltip for clarification in filter include switch component (link, link)
  • Prevent switch label from expanding and overlapping with switch button in switch.scss (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia joanagmaia merged commit 592bde7 into CrowdDotDev:main Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C-1523] Improve UX copy of negative filters
2 participants