Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-based filter in members page for Job title #1438

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Sep 6, 2023

Changes proposed ✍️

What

Fixes #1241

🤖 Generated by Copilot at abef4fc

Added a new filter for job title to the member filters on the frontend. Modified frontend/src/modules/member/config/filters/main.ts to import and use the new filter configuration from frontend/src/modules/member/config/filters/jobTitle/config.ts.

🤖 Generated by Copilot at abef4fc

Filter by jobTitle
A new string attribute
Autumn of careers

Why

How

🤖 Generated by Copilot at abef4fc

  • Add a new filter for job title of members (link)
  • Include the job title filter in the member filters object (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In frontend/src/shared/modules/filters/services/custom-attributes.service.ts
can you add an extra validation for filtering?
.filter((attribute) => attribute.show && attribute.name !== 'jobTitle')

We were actually already displaying jobTitle in our custom attributes. Without this modification the filter will appear twice on the list.

Sorry for the confusion

@peoray
Copy link
Contributor Author

peoray commented Sep 6, 2023

@joanagmaia updated :)

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia
Copy link
Contributor

Hey @peoray just merged 2 of your PRs 😄
Can you resolve conflict so that I can also merge this one after? Thanks!

@peoray
Copy link
Contributor Author

peoray commented Sep 7, 2023

@joanagmaia resolved :)

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia joanagmaia merged commit d9850d4 into CrowdDotDev:main Sep 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C-2038] "Job title" filter in Members list
2 participants