-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text-based filter in members page for Job title #1438
Add text-based filter in members page for Job title #1438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In frontend/src/shared/modules/filters/services/custom-attributes.service.ts
can you add an extra validation for filtering?
.filter((attribute) => attribute.show && attribute.name !== 'jobTitle')
We were actually already displaying jobTitle in our custom attributes. Without this modification the filter will appear twice on the list.
Sorry for the confusion
@joanagmaia updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Hey @peoray just merged 2 of your PRs 😄 |
@joanagmaia resolved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Changes proposed ✍️
What
Fixes #1241
🤖 Generated by Copilot at abef4fc
Added a new filter for job title to the member filters on the frontend. Modified
frontend/src/modules/member/config/filters/main.ts
to import and use the new filter configuration fromfrontend/src/modules/member/config/filters/jobTitle/config.ts
.
🤖 Generated by Copilot at abef4fc
Why
How
🤖 Generated by Copilot at abef4fc
Checklist ✅
Feature
,Improvement
, orBug
.