Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-select filters on organizations, members and activities filter list #1441

Merged
merged 9 commits into from
Sep 14, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Sep 7, 2023

…r-member-list# Changes proposed ✍️

What

Fixed #1243

🤖 Generated by Copilot at 5d52afa

Changed several filters from single-select to multi-select components, to allow more flexible filtering of activities, channels, members, and organizations. Added a new filter for job title in the member module, to enable filtering by this attribute. Updated the config files and the custom-attributes service to reflect these changes.

🤖 Generated by Copilot at 5d52afa

Sing, O Muse, of the skillful coder who changed the filters
Of many modules, to make them more flexible and useful
He added a new jobTitle filter to the member module
Like Hephaestus forging a new tool for the gods on Olympus

Why

How

🤖 Generated by Copilot at 5d52afa

  • Replace the CrSelectFilter component with the CrMultiSelectFilter component in the activityType and channel filters of the activity module and the activityType filter of the member module, to allow the user to select multiple options instead of one (link, link, link, link, link, link).

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@peoray
Copy link
Contributor Author

peoray commented Sep 8, 2023

@joanagmaia please review when you need can. I can't find a way to request your review silently

@peoray
Copy link
Contributor Author

peoray commented Sep 12, 2023

@joanagmaia resolved

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thanks for this work!

@joanagmaia joanagmaia merged commit 10f530e into CrowdDotDev:main Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C-2040] Multi-select on all filters with multiple options
2 participants