-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-select filters on organizations, members and activities filter list #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@joanagmaia please review when you need can. I can't find a way to request your review silently |
joanagmaia
requested changes
Sep 11, 2023
frontend/src/modules/member/config/filters/activityType/config.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/member/config/filters/activityType/config.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/activity/config/filters/activityType/ActivityTypeFilter.vue
Outdated
Show resolved
Hide resolved
frontend/src/modules/activity/config/filters/channel/ChannelFilter.vue
Outdated
Show resolved
Hide resolved
frontend/src/modules/activity/config/filters/activityType/config.ts
Outdated
Show resolved
Hide resolved
frontend/src/modules/member/config/filters/activityType/ActivityTypeFilter.vue
Outdated
Show resolved
Hide resolved
@joanagmaia resolved |
joanagmaia
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for this work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r-member-list# Changes proposed ✍️
What
Fixed #1243
🤖 Generated by Copilot at 5d52afa
Changed several filters from single-select to multi-select components, to allow more flexible filtering of activities, channels, members, and organizations. Added a new filter for job title in the member module, to enable filtering by this attribute. Updated the config files and the custom-attributes service to reflect these changes.
🤖 Generated by Copilot at 5d52afa
Why
How
🤖 Generated by Copilot at 5d52afa
Checklist ✅
Feature
,Improvement
, orBug
.