-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added time frame granularity to urls for reports #1452
feat: added time frame granularity to urls for reports #1452
Conversation
Hey @Pradumn27, thanks so much for this awesome contribution! |
frontend/src/modules/report/components/templates/report-template-filters.vue
Show resolved
Hide resolved
Any updates here @joanagmaia ? |
Thanks for all the comments and for updating the code! Just replied to your question |
Have made the changes @joanagmaia |
Any updates here @joanagmaia ? |
Hey! sorry there's been a lot going on 😓 I'll try to close this one today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Changes proposed ✍️
/fixes #712
/claim #712
Have added query parameters in URLs that address the granularity of the selected fields in reports. It addresses both the globally selected and the widget-wise selected parameters.
Here's a video demonstration : https://www.veed.io/view/37ff864b-154c-4bc9-87bb-13c3d7c2bb6c?panel=share
What
🤖 Generated by Copilot at 5ce9ef7
This pull request enhances the filter functionality of various widget components by syncing the filter props with the query parameters using the Vue Router API. It also improves the code style and readability of the components by following eslint rules and refactoring some elements. It adds some utility functions in
widget-utility.js
to get the selected period and granularity from the query parameters. The affected components are in thefrontend/src/modules/widget/components
folder and includereport-template-filters.vue
,widget-activities-leaderboard.vue
,widget-activities-platform.vue
,widget-new-activities.vue
,widget-total-activities.vue
,widget-active-leaderboard-members.vue
,widget-active-members.vue
,widget-total-members.vue
,widget-benchmark.vue
, andwidget-monthly-active-contributors.vue
.
🤖 Generated by Copilot at 5ce9ef7
Why
How
🤖 Generated by Copilot at 5ce9ef7
Checklist ✅
Feature
,Improvement
, orBug
.