Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added time frame granularity to urls for reports #1452

Merged

Conversation

Pradumn27
Copy link
Contributor

@Pradumn27 Pradumn27 commented Sep 9, 2023

Changes proposed ✍️

/fixes #712
/claim #712

Have added query parameters in URLs that address the granularity of the selected fields in reports. It addresses both the globally selected and the widget-wise selected parameters.

Here's a video demonstration : https://www.veed.io/view/37ff864b-154c-4bc9-87bb-13c3d7c2bb6c?panel=share

What

🤖 Generated by Copilot at 5ce9ef7

This pull request enhances the filter functionality of various widget components by syncing the filter props with the query parameters using the Vue Router API. It also improves the code style and readability of the components by following eslint rules and refactoring some elements. It adds some utility functions in widget-utility.js to get the selected period and granularity from the query parameters. The affected components are in the frontend/src/modules/widget/components folder and include report-template-filters.vue, widget-activities-leaderboard.vue, widget-activities-platform.vue, widget-new-activities.vue, widget-total-activities.vue, widget-active-leaderboard-members.vue, widget-active-members.vue, widget-total-members.vue, widget-benchmark.vue, and widget-monthly-active-contributors.vue.

🤖 Generated by Copilot at 5ce9ef7

router and query
sync the filters for widgets
autumn code cleanup

Why

How

🤖 Generated by Copilot at 5ce9ef7

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2023

CLA assistant check
All committers have signed the CLA.

@joanagmaia
Copy link
Contributor

Hey @Pradumn27, thanks so much for this awesome contribution!
Will try to review this one as soon as possible 😄

@Pradumn27
Copy link
Contributor Author

Any updates here @joanagmaia ?

@joanagmaia
Copy link
Contributor

Any updates here @joanagmaia ?

Thanks for all the comments and for updating the code! Just replied to your question

@Pradumn27
Copy link
Contributor Author

Thanks for all the comments and for updating the code! Just replied to your question

Have made the changes @joanagmaia

@Pradumn27
Copy link
Contributor Author

Any updates here @joanagmaia ?

@joanagmaia
Copy link
Contributor

Any updates here @joanagmaia ?

Hey! sorry there's been a lot going on 😓 I'll try to close this one today

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia joanagmaia merged commit b140c2c into CrowdDotDev:main Oct 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C-1072] [C-1073] Keep timeframe in default reports URL
3 participants