Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stackoverflow profile links #1462

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Sep 11, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 3e25509

Added support for custom platform URLs and icons based on user attributes. Refactored platform URL functions to use attributes as a fallback and handle missing or invalid data. Updated app-platform and platform-svg-icon components to accept attributes prop and render platform-specific elements. Fixed a minor bug in backup-url prop.

🤖 Generated by Copilot at 3e25509

Sing, O Muse, of the mighty pull request
That refactored the url function for all
The platforms that the users could select
To show their identities on the wall.

Why

How

🤖 Generated by Copilot at 3e25509

  • Refactored the platform URL functions for all integrations to accept an object with username and attributes properties instead of just username and to return null if the username is not provided or the attributes do not contain a valid platform URL (link, link, link, link, link, link, link, link, link, link)
  • Added the attributes prop to the app-platform component in various files and passed the platform attributes to the platform URL functions and the platform SVG icon component (link, link, link, link, link)
  • Added the attributes prop to the app-platform-popover component in platform.vue and passed the platform attributes to the platform popover component (link, link)
  • Added the attributes prop to the app-platform-svg-icon component in platform-popover.vue and platform-svg-icon.vue and passed the platform attributes to the SVG icon component (link, link, link, link)
  • Removed the unused defineProps import from platform-svg-icon.vue (link)
  • Changed the href computed property in platform-list.vue, platform-popover.vue, and platform.vue to accept an object with username and attributes properties instead of just username and to use the props.attributes.url object as a fallback source of platform URLs (link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Sep 11, 2023
@joanagmaia joanagmaia self-assigned this Sep 11, 2023
@joanagmaia joanagmaia merged commit c880bee into main Sep 13, 2023
6 checks passed
@joanagmaia joanagmaia deleted the bugfix/stackoverflow-profiles-links branch September 13, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants