Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub unstars #1464

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix GitHub unstars #1464

merged 1 commit into from
Sep 11, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Sep 11, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at d348a6a

This pull request improves the accuracy of the date of starring a repository on GitHub by using the webhookCreatedAt property from the webhook event data. It adds this property to the IWebhookData and IIntegrationStream interfaces, and modifies the data parsing and processing functions accordingly.

🤖 Generated by Copilot at d348a6a

To process GitHub stars with precision
We added a new date decision
We use webhookCreatedAt
As the starredAt stat
And removed the fallback condition

Why

How

🤖 Generated by Copilot at d348a6a

  • Add createdAt property to IWebhookData interface to store webhook event timestamp (link)
  • Add iw."createdAt" column to SQL query to select webhook data from integration_webhook table (link)
  • Add webhookCreatedAt property to object passed to processWebhookStream function to handle different webhook types (link)
  • Use webhookCreatedAt value as starredAt value for GitHub star webhook events, instead of current date or optional date value (link, link, link, link)
  • Make date parameter mandatory for parseWebhookStar function, and simplify object passed to parseWebhookData function (link, link)
  • Assign webhookCreatedAt value to variable in handler function, and remove date property from ctx.stream.data object (link, link)
  • Add optional webhookCreatedAt property to IIntegrationStream interface to store webhook event timestamp for integration streams (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 37083bc into main Sep 11, 2023
9 checks passed
@garrrikkotua garrrikkotua deleted the fix/github-unstars branch September 11, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant