Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force typescript for org enrich config #1467

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Sep 12, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 71a3c29

This pull request adds default exports and improves type safety for the frontend enrichment modules for organizations. It also introduces a new getEnrichmentConfig function and an EnrichmentConfig type to simplify and standardize the enrichment configuration objects. Additionally, it replaces the attributesTypes object with the AttributeType enum for consistency. These changes affect the files in the frontend/src/modules/organization/config/enrichment directory.

🤖 Generated by Copilot at 71a3c29

AttributeType enum
simplifies enrichment code
refactor in autumn

Why

How

🤖 Generated by Copilot at 71a3c29

  • Replace the import of attributesTypes with AttributeType enum in all enrichment files (link-link, link)
  • Add default exports of the enrichment objects to the end of the files that were missing them (link, link, link, link, link, link, link, link, link, link)
  • Type the AverageTenureByLevel object as Record<string, string> in averageTenureByLevel.ts (link)
  • Add as any cast to avoid TypeScript error in employeeCountByMonth.ts and grossAdditionsByMonth.ts (link, link)
  • Create enrichmentConfig array and OrganizationEnrichmentConfig interface in index.ts to store and export the enrichment objects (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label Sep 12, 2023
@gaspergrom gaspergrom self-assigned this Sep 12, 2023
@gaspergrom gaspergrom merged commit fe5b3f0 into main Sep 12, 2023
6 checks passed
@gaspergrom gaspergrom deleted the improvement/organization-enrich-ts branch September 12, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants