Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute types import #1471

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix attribute types import #1471

merged 1 commit into from
Sep 12, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Sep 12, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 233f56a

This pull request introduces an AttributeType enum to replace the attributesTypes object for defining and rendering different types of attributes for members and organizations. It refactors several components that use attribute types, such as member-form-attributes.vue, organization-form-attributes.vue, and organization-view-aside.vue, to use the enum instead of the object, for better consistency and readability of the code.

🤖 Generated by Copilot at 233f56a

Sing, O Muse, of the skillful refactorer
Who changed the code of attributes with care
And made them use an enum, not an object
To show their types with clarity and respect

Why

How

🤖 Generated by Copilot at 233f56a

  • Refactor attribute types to use AttributeType enum instead of attributesTypes object for consistency and readability (link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Update conditional rendering of dynamic components in member-form-attributes.vue, organization-form-attributes.vue, and _aside-enriched.vue to use enum values (link, link, link, link, link)
  • Update computed properties visibleAttributes and shouldShowAttributes in _aside-enriched.vue and organization-view-aside.vue to use enum values (link, link)
  • Update function shouldShowAttribute in organization-form-page.vue to use enum values (link)
  • Import AttributeType enum instead of attributesTypes object in all affected files (link, link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia merged commit 2135082 into main Sep 12, 2023
7 checks passed
@joanagmaia joanagmaia deleted the bugfix/import-attribute-types branch September 12, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant