Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for truncated emails in member profile #1476

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Sep 12, 2023

Changes proposed ✍️

What

Fixes #1289

🤖 Generated by Copilot at b168820

Added tooltip and truncate class to email address in view/_aside/_aside-identities.vue. This improves the layout and usability of the member identities component.

🤖 Generated by Copilot at b168820

Email overflows
tooltip and truncate
Show it in winter

Why

How

🤖 Generated by Copilot at b168820

  • Wrap email address in tooltip and truncate it to prevent overflow (frontend/src/modules/member/components/view/_aside/_aside-identities.vue, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@peoray
Copy link
Contributor Author

peoray commented Sep 12, 2023

@joanagmaia please take a look

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Just added a comment to remove one console.log

@joanagmaia joanagmaia merged commit 371839c into CrowdDotDev:main Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C-1137] Email overflow on Member profile
2 participants