-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix email column inconsistencies in members list #1479
Fix email column inconsistencies in members list #1479
Conversation
@yeganathan18 please take a look :) |
@peoray Looks good to me, It would be great if you could attach a screenshot, just to ensure everything is good on UI 🙂 |
</template> | ||
<div class="flex flex-wrap gap-3 my-1"> | ||
<el-tooltip | ||
v-for="email of scope.row.emails" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Nuno's image might have induced an error, but the goal inside the popover is that it only displays the emails that are not visible on this list.
So let's say you have 5 emails. On the list it should display 3 and on the popover it should show the remaining 2 (that's why there's the +2 tag to indicate that 😄 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got that 👍🏽 , will make the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Changes proposed ✍️
What
Fixes #1164
🤖 Generated by Copilot at dd328ab
Improved the UI and functionality of the member list table component in
member-list-table.vue
. Fixed a bug with an import statement.
🤖 Generated by Copilot at dd328ab
Why
How
🤖 Generated by Copilot at dd328ab
storeToRefs
function (link)Checklist ✅
Feature
,Improvement
, orBug
.