Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of custom platforms in org list #1482

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Sep 13, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 840d6d2

Added optional chaining to getPlatformDetails calls and custom icon class prop to PlatformIcon component. This improves error handling and UI for community platforms as identity sources.

🤖 Generated by Copilot at 840d6d2

getPlatformDetails?
No error if not found now
Autumn leaves falling

Why

How

🤖 Generated by Copilot at 840d6d2

  • Add optional chaining operator to prevent errors when platform is not found and allow custom icon class for community platform (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Sep 13, 2023
@gaspergrom gaspergrom self-assigned this Sep 13, 2023
@gaspergrom gaspergrom merged commit 819e846 into main Sep 13, 2023
7 checks passed
@gaspergrom gaspergrom deleted the bugfix/custom-identity-org-list branch September 13, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants