Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change template to default #1491

Merged
merged 3 commits into from
Sep 20, 2023
Merged

chore: change template to default #1491

merged 3 commits into from
Sep 20, 2023

Conversation

a0m0rajab
Copy link
Contributor

@a0m0rajab a0m0rajab commented Sep 13, 2023 •
edited by ghost

Changes proposed ✍️

What

Changed the template name to default.​

Close #489

🤖 Generated by Copilot at d545e89

/reports route changed
To match the backend endpoint
Autumn leaves confusion

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

joanagmaia
joanagmaia approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia
Copy link
Contributor

Will try to merge this today. Thanks for the work!

@joanagmaia
Copy link
Contributor

@a0m0rajab could you sign the CLA? So that I can merge?

@a0m0rajab
Copy link
Contributor Author

@joanagmaia done! thank you for accepting it.

@joanagmaia joanagmaia merged commit bde156c into CrowdDotDev:main Sep 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanagmaia joanagmaia joanagmaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C-618] Default report URL should be "/reports/default" not "/reports/template"
3 participants
@a0m0rajab @CLAassistant @joanagmaia