Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identities management #1493

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Fix identities management #1493

merged 5 commits into from
Sep 14, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Sep 14, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 852ca8a

This pull request improves the organization form page by fixing a bug with empty identity links and adding support for username and url fields for each identity. It also updates the frontend and backend data models to be consistent.

🤖 Generated by Copilot at 852ca8a

The org form had a bug with the links
That showed up for some identities' blinks
So they added username and url
And refactored the data to unfurl
The backend API format for the syncs

Why

How

🤖 Generated by Copilot at 852ca8a

  • Prevent empty links and enable identities only if they have a url in the organization form (link, link, link, link, link)
  • Refactor the data structure of identities to match the backend model and simplify the input change handler (link)
  • Add username and url properties to the identity objects passed to the OrganizationFormIdentities component in organization-form-page.vue (link)
  • Map the identities array to the format expected by the backend API before saving or updating the organization in organization-form-page.vue (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Sep 14, 2023
@gaspergrom gaspergrom self-assigned this Sep 14, 2023
@gaspergrom gaspergrom merged commit fd56cbd into main Sep 14, 2023
6 checks passed
@gaspergrom gaspergrom deleted the bugfix/org-identities-rendering branch September 14, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants