Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubspot integration sync errors & better error handling #1503

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Sep 15, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at d134449

This pull request improves the error handling, data consistency, and synchronization logic of the data sink and integration sync workers. It also adds support for syncing organizations with HubSpot and other external platforms. The main changes are in the member.service.ts, organization.service.ts, member.sync.service.ts, organization.sync.service.ts, and errors.ts files in the services/apps folder, and the batchUpdateMembers.ts and batchUpdateOrganizations.ts files in the services/libs/integrations folder.

🤖 Generated by Copilot at d134449

We are the sync masters, we control the data flow
We handle the errors, we make the integrations glow
We use the sourceId, we find the organization
We update the member, we rule the automation

Why

How

🤖 Generated by Copilot at d134449

  • Prevent data sink worker from crashing when encountering invalid members (link, link)
  • Ensure organization service methods are executed within the same transaction context (link, link)
  • Add error message functions for missing integrations and automations in errors.ts (link)
  • Use error message functions and skip processing of sync requests when integration, automation or member are null in member.sync.service.ts (link, link, link, link, link)
  • Add sourceId property to member objects for syncing with external platforms in member.sync.service.ts (link, link, link, link)
  • Add sourceId property to organization objects for syncing with external platforms in organization.sync.service.ts (link, link, link)
  • Skip processing of null members or organizations for updating in HubSpot in batchUpdateMembers.ts and batchUpdateOrganizations.ts (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review September 15, 2023 12:11
@epipav epipav self-assigned this Sep 18, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Sep 18, 2023
@epipav epipav merged commit 2d68ecf into main Sep 18, 2023
8 checks passed
@epipav epipav deleted the bugfix/hubspot-integration-sync-errors branch September 18, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants