Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Log rocket logging #1518

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Improve Log rocket logging #1518

merged 4 commits into from
Sep 21, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Sep 19, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 07ac542

This pull request adds a feature flag for LogRocket and refactors the frontend app to use a custom LogRocket module that respects the flag. It also fixes a typo and adds a User interface.

🤖 Generated by Copilot at 07ac542

The feature flag module was moved
To utils, and then it was proved
That useLogRocket could
Handle errors quite good
If the flag for LogRocket was approved

Why

How

🤖 Generated by Copilot at 07ac542

  • Move featureFlag module to utils folder and update import paths in several files (link, link, link, link, link, link, link, link, link, link, link, link)
  • Create custom LogRocket module in frontend/src/utils/logRocket/index.ts that exports useLogRocket function (link)
  • Import useLogRocket function instead of logrocket module in main.ts, errors.js, identify.js, and featureFlag/index.js (link, link, link, link)
  • Use initLogRocket function to initialize LogRocket client with app ID and feature flag in main.ts and featureFlag/index.js (link, link)
  • Use captureException function to handle errors with LogRocket and feature flag in main.ts, errors.js, and featureFlag/index.js (link, link, link, link, link)
  • Use identify function to identify user with LogRocket and feature flag in identify.js (link)
  • Add logRocket feature flag to FEATURE_FLAGS object in featureFlag/index.js (link)
  • Define User interface in frontend/src/modules/user/types/User.ts (link)
  • Fix typo in dashboard-conversation-item.vue component (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Sep 19, 2023
@joanagmaia joanagmaia self-assigned this Sep 19, 2023
@gaspergrom gaspergrom self-requested a review September 19, 2023 15:21
@joanagmaia joanagmaia merged commit 5651cf6 into main Sep 21, 2023
6 checks passed
@joanagmaia joanagmaia deleted the improvement/log-rocket branch September 21, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants