Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix member error if no suggestions #1526

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Sep 20, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 2e71cd7

Fixed a bug in member-merge-suggestions-page.vue that caused an error when the members array had only one element. Added a condition to check the array length before comparing the members.

🤖 Generated by Copilot at 2e71cd7

members array
check length before compare
autumn leaves falling

Why

How

🤖 Generated by Copilot at 2e71cd7

  • Add a condition to prevent index out of bounds error when comparing members to be merged (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Sep 20, 2023
@gaspergrom gaspergrom self-assigned this Sep 20, 2023
@gaspergrom gaspergrom changed the title Fix member suggestion failing Fix member error if no suggestions Sep 20, 2023
@gaspergrom gaspergrom merged commit 5b22bc3 into main Sep 20, 2023
7 checks passed
@gaspergrom gaspergrom deleted the bugfix/member-suggestion-page branch September 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants