Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom date ranges to custom reports #1536

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Sep 21, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at ce9c9da

This pull request adds a custom date range feature to the widget cube query builder, and improves the usability and clarity of the widget cube builder drawer. It modifies the DateRangeSelect.vue, widget-cube-builder.vue, and report-grid-layout.vue components, and adds some custom styles to the date-picker.scss file.

🤖 Generated by Copilot at ce9c9da

To build widgets with cubes and dates
We added some props and some traits
The action and title
Make the drawer more vital
And the date-picker styles look great

Why

How

🤖 Generated by Copilot at ce9c9da

  • Add a new prop action to the widget-cube-builder.vue and widgetDrawer components, to indicate whether the drawer is for editing or adding a new widget (link, link, link)
  • Update the title prop of the app-drawer component, to dynamically compute the title based on the action prop (link)
  • Update the model-value prop of the el-select component in the DateRangeSelect.vue component, to bind it to a new data property selectedDateRange, which is computed from the timeDimensions prop (link)
  • Add a new conditional block to the DateRangeSelect.vue component template, to render a el-date-picker component if the selectedDateRange is equal to 'Custom' (link)
  • Add a new option 'Custom' to the dateRangeItems data property of the DateRangeSelect.vue component, to allow the user to select a custom date range using the el-date-picker component (link)
  • Modify the changeHandler method of the DateRangeSelect.vue component, to handle the 'Custom' option, set the default custom date range and granularity, and emit the custom date range to the cube query (link)
  • Add a new watch option to the DateRangeSelect.vue component, to watch the timeDimensions prop and update the selectedDateRange and selectedCustomDateRange data properties accordingly (link)
  • Add a new method disabledDate to the DateRangeSelect.vue component, to disable invalid dates in the el-date-picker component (link)
  • Add some custom CSS variables and styles to the date-picker.scss file, to match the design and color scheme of the app (link)
  • Add some custom styles to the DateRangeSelect.vue component, to style the el-date-picker component and its popper (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Sep 21, 2023
@joanagmaia joanagmaia self-assigned this Sep 21, 2023
@joanagmaia joanagmaia merged commit 2d2aab4 into main Sep 25, 2023
6 checks passed
@joanagmaia joanagmaia deleted the improvement/custom-date-ranges-reports branch September 25, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants