Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding only one member by e-mail even if there are more when enriching #1539

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Sep 22, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at f6aedcd

Added a limit clause to the SQL query in member.repo.ts to avoid duplicate email issues. This improves the reliability of the findOneByEmail method and the data sink worker service.

🤖 Generated by Copilot at f6aedcd

findOneByEmail
adds limit to SQL query
fall leaves no duplicates

Why

How

🤖 Generated by Copilot at f6aedcd

  • Add a limit clause to the SQL query for finding a member by email (link). This ensures that only one row is returned, which matches the expected behavior of the findOneByEmail method in member.repo.ts. This change prevents potential errors or inconsistencies if there are duplicate emails in the database.

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav self-assigned this Sep 22, 2023
@epipav epipav added the Bug Created by Linear-GitHub Sync label Sep 22, 2023
@epipav epipav marked this pull request as ready for review September 22, 2023 09:54
@epipav epipav merged commit 62559b4 into main Sep 22, 2023
9 checks passed
@epipav epipav deleted the bugfix/member-findByEmail-limit branch September 22, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant