Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sanitizing URLs that doesn't start with http when getting organization domain #1540

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Sep 22, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at d96c302

Improved the getOrganizationDomain function to handle HubSpot contacts with non-URL website fields. This prevents errors when importing contacts from HubSpot to Crowd.dev.

🤖 Generated by Copilot at d96c302

getOrganizationDomain
handles bad websites better
fall leaves no errors

Why

How

🤖 Generated by Copilot at d96c302

  • Handle invalid or missing website fields when importing HubSpot contacts (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav added the Bug Created by Linear-GitHub Sync label Sep 22, 2023
@epipav epipav self-assigned this Sep 22, 2023
@epipav epipav marked this pull request as ready for review September 22, 2023 13:17
@epipav epipav merged commit 41ee564 into main Sep 22, 2023
9 checks passed
@epipav epipav deleted the bugfix/organization-domain-sanitization-errors branch September 22, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant