Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge organizations with same website #1553

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

epipav
Copy link
Collaborator

@epipav epipav commented Sep 25, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 27cd3ef

This pull request enhances the organization service and database schema to prevent duplicate websites for the same tenant. It fixes a typo in organizationService.ts and adds a data validation check and a unique index in V1695669657__organizationsAddWebsiteUniqueIdx.sql.

🤖 Generated by Copilot at 27cd3ef

Oh we are the coders of the organizations table
We make it unique and stable
We fix the typos and the bugs with a grin
And we validate the data that goes in

Why

How

🤖 Generated by Copilot at 27cd3ef

  • Create a unique index on the website and tenantId columns of the organizations table to prevent duplicate websites for the same tenant (link)
  • Fix a typo in the comment of the deleteOrganization method to match the code logic (link)
  • Add a condition to check if the data object has an identities property before validating and comparing the identities of the organization being updated in the organizationService.ts file (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@epipav epipav marked this pull request as ready for review September 25, 2023 19:49
@epipav epipav self-assigned this Sep 25, 2023
@epipav epipav added the Improvement Created by Linear-GitHub Sync label Sep 25, 2023
…hub.com:CrowdDotDev/crowd.dev into improvement/merge-organizations-with-same-email
@epipav epipav merged commit 110b486 into main Sep 26, 2023
8 checks passed
@epipav epipav deleted the improvement/merge-organizations-with-same-email branch September 26, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants