Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form page freezing #1554

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix form page freezing #1554

merged 1 commit into from
Sep 26, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Sep 26, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 6cde9a8

Refactored onMounted hook and getMemberCustomAttributes function in member-form-page.vue to use promises instead of async/await. This improves the page performance and UI responsiveness.

🤖 Generated by Copilot at 6cde9a8

onMounted hook
uses promise, not await
faster UI now

Why

How

🤖 Generated by Copilot at 6cde9a8

  • Refactor onMounted hook to use promise-based approach instead of async/await (link)
  • Remove unnecessary async modifier from getMemberCustomAttributes function (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Sep 26, 2023
@gaspergrom gaspergrom self-assigned this Sep 26, 2023
@gaspergrom gaspergrom merged commit 970884f into main Sep 26, 2023
6 of 7 checks passed
@gaspergrom gaspergrom deleted the bugfix/member-form-page-freeze branch September 26, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants