Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activities and conversations pagination #1558

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Sep 26, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 5b3cb0f

Refactored the fetch function for data fetching in the frontend. Added default values for offset and limit parameters in the activity-list.vue component.

🤖 Generated by Copilot at 5b3cb0f

fetch function reused
refactoring for data types
autumn leaves fall fast

Why

How

🤖 Generated by Copilot at 5b3cb0f

  • Refactor fetch function to reuse logic for fetching conversations and activities (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Sep 26, 2023
@joanagmaia joanagmaia self-assigned this Sep 26, 2023
@joanagmaia joanagmaia merged commit 82719e4 into main Sep 26, 2023
7 checks passed
@joanagmaia joanagmaia deleted the bugfix/activities-pagination branch September 26, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants