Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-select organization filter in members, organizations and activities lists #1560

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Sep 26, 2023

Changes proposed ✍️

What

Fixes #1240

🤖 Generated by Copilot at 4f79805

Added a new organizations filter option to the activity, member, and organization list pages. This filter allows users to see entities related to their organizations. Implemented the filter config, logic, and UI for the new option in the respective modules and shared components. Added a logo property to the filter option interface and rendered logos or icons for the organization options.

🤖 Generated by Copilot at 4f79805

To filter the lists by organizations
We added some new configurations
With MultiSelectAsyncFilter
And OrganizationService helper
We improved the UI and the relations

Why

How

🤖 Generated by Copilot at 4f79805

  • Add a new filter option for the activity, member, and organization list pages that allows users to filter by the organizations they belong to (link, link, link, link, link, link, link)
  • Import the organizations filter config from the activity module in the frontend/src/modules/activity/config/filters/main.ts file (link)
  • Register the organizations filter config in the activityFilters object in the same file (link)
  • Define the organizations filter config as a MultiSelectAsyncFilterConfig type in the frontend/src/modules/activity/config/filters/organizations/config.ts file (link)
  • Use the OrganizationService to fetch and populate the organization options in the filter config (link)
  • Customize the itemLabelRenderer and apiFilterRenderer methods for the filter config to display and send the filter values (link)
  • Repeat the same steps for the member and organization modules in the corresponding files (link, link, link, link)
  • Enhance the UI for the new filter option by rendering a logo or an icon for the organization options in the MultiSelectAsyncFilter.vue component (link, link)
    • Add a conditional template to the component that checks the filter config id and renders a logo or an icon accordingly (link)
    • Add a new optional property logo to the MultiSelectAsyncFilterOption interface that represents the logo URL for the organization option (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia self-requested a review September 27, 2023 22:05
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia joanagmaia merged commit f528cc9 into CrowdDotDev:main Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C-2037] "Organization" filter in Members, Organizations, and Activities lists
2 participants