Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize sleep time in concurrent request limiter #1606

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 2, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 9e0004b

Added randomness to sleep time between retries in checkConcurrentRequestLimit method of ConcurrentRequestLimiter class. This improves the rate limiting mechanism for external integrations by avoiding synchronization issues.

🤖 Generated by Copilot at 9e0004b

checkConcurrentRequestLimit
Sleep time now random
Avoiding race conditions

Why

How

🤖 Generated by Copilot at 9e0004b

  • Add a random factor to the sleep time between retries in the concurrent request limiter (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 591587c into main Oct 2, 2023
7 checks passed
@garrrikkotua garrrikkotua deleted the improve/better-concurrent-rate-limiter branch October 2, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant