Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve concurrent request limiter #1607

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 2, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 64ca2a8

Added a new parameter to ConcurrentRequestLimiter to limit the cache key lifetime in Redis. This improves the performance and reliability of the rate limiting feature in services/libs/redis.

🤖 Generated by Copilot at 64ca2a8

Sing, O Muse, of the cunning coder who devised
A new parameter for the ConcurrentRequestLimiter,
The swift and skillful class that guards the Redis cache
From the onslaught of concurrent requests that strain its power.

Why

How

🤖 Generated by Copilot at 64ca2a8

  • Add maxLockTimeSeconds parameter to ConcurrentRequestLimiter constructor and methods to prevent stale cache keys from blocking concurrent requests (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 42fed39 into main Oct 2, 2023
7 checks passed
@garrrikkotua garrrikkotua deleted the improve/fine-tune-limiter-seconds branch October 2, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant