Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune concurrent limiter and use for loop instead of recursion #1609

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 2, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 3df2400

Increased the limit of concurrent requests to GitHub from 2 to 4 and refactored the rate limiter logic to use a for loop. These changes aim to improve the performance and reliability of the GitHub integration service.

🤖 Generated by Copilot at 3df2400

GitHub requests rise
For faster integration
Loop replaces call

Why

How

🤖 Generated by Copilot at 3df2400

  • Increase the maximum number of concurrent requests to GitHub from 2 to 4 to improve the performance and throughput of the GitHub integration service (link)
  • Refactor the checkConcurrentRequestLimit method to use a for loop instead of a recursive call to avoid potential stack overflow errors and simplify the logic (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit b05c973 into main Oct 2, 2023
6 checks passed
@garrrikkotua garrrikkotua deleted the improve/tune-concurrent-limiter branch October 2, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant