Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OctoKit #1616

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update OctoKit #1616

merged 2 commits into from
Oct 3, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 3, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 834ffc2

This pull request refactors and updates the code for the GitHub integration service. It removes obsolete and redundant code, and uses a new library to handle the app installation token. It also updates the dependencies to use the latest versions of the GitHub API libraries.

🤖 Generated by Copilot at 834ffc2

We're breaking free from the old code of doom
We're updating our dependencies to the latest tune
We're simplifying our auth flow with the octokit crew
We're removing the redundant logic that was slowing us down

Why

How

🤖 Generated by Copilot at 834ffc2

  • Update @octokit/auth-app and @octokit/graphql dependencies in package.json (link)
  • Remove unused and obsolete getAppToken function and its import (link)
  • Remove redundant and unnecessary caching logic for GitHub app installation token (link)
  • Refactor getGithubToken function to use @octokit/auth-app library for authentication and authorization (link)
  • Replace ctx.integration.token property with getGithubToken function in all stream processing functions (link, link, link, link, link, link, link, link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit f26998d into main Oct 3, 2023
9 checks passed
@garrrikkotua garrrikkotua deleted the improve/update-octokit branch October 3, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant