Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update member to contact in app #1621

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Oct 3, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 313b981

This pull request renames members to contacts throughout the frontend and backend codebase to align with the HubSpot integration and to improve the clarity of the terminology for the users. It updates the translation files, the integration components, the automation config files, the filter options, the trigger options, the suggested tasks, the quickstart guide, and the error messages to use the term contact instead of member. It also updates the corresponding test files to reflect the changes.

🤖 Generated by Copilot at 313b981

The app had a term to correct
It was member, but now it's contact
So they changed every file
With a search and replace style
And hoped that it wouldn't affect

Why

How

🤖 Generated by Copilot at 313b981

  • Rename "members" to "contacts" in various places to reflect the new naming convention for the people in the community (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Update the quickstart guide for enriching a contact to link to the contacts page instead of the members page (link)
  • Update the tooltip for the analytics dashboard to explain how to access the contacts page (link)
  • Update the test files for the taskRepository and the tenantService to match the updated suggested tasks in backend/src/database/initializers/suggested-tasks.json (link, link)
  • Update the HubSpot integration settings component to add a label for the contact attributes option (link)
  • Update the dev.to integration component to add a description for monitoring articles from individual users (link)
  • Update the GitHub integration component to add a message for requiring admin permissions to connect the integration (link)
  • Update the HubSpot automation action component to add a label for syncing all members from the matching organizations (link)
  • Update the HubSpot automation action option file to add a description for the option to add a member to a HubSpot contacts list (link)
  • Update the HubSpot automation paywall component to add a body for the paywall message (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Improvement Created by Linear-GitHub Sync label Oct 3, 2023
@joanagmaia joanagmaia self-assigned this Oct 3, 2023
@peoray
Copy link
Contributor

peoray commented Oct 3, 2023

What's the motivation in changing members to contacts?

Copy link
Member

@yeganathan18 yeganathan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question: Are we still going to work on the code using the member context, rather than as contacts? I believe the changes are only for the copy stuff

@yeganathan18
Copy link
Member

Hey @peoray, we've switched "Members" to "Contacts" because our platform is expanding beyond just community members. Exciting new updates and changes are coming up early next year! 😛

@peoray
Copy link
Contributor

peoray commented Oct 4, 2023

That's awesome, well done to everyone involved

@joanagmaia
Copy link
Contributor Author

quick question: Are we still going to work on the code using the member context, rather than as contacts? I believe the changes are only for the copy stuff

Yeah right now I've only updated copy. I think it could become confusing since all files and methods are still with members, but for now I think it's safer to just update copy

Copy link
Member

@yeganathan18 yeganathan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@joanagmaia joanagmaia merged commit 9878ae5 into main Oct 6, 2023
11 checks passed
@joanagmaia joanagmaia deleted the improvement/update-member-copy branch October 6, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants